[coreboot] New patch to review for coreboot: e6cd930 libpayload: Fix use of virtual pointers in sysinfo

Nico Huber (nico.huber@secunet.com) gerrit at coreboot.org
Fri Dec 7 17:43:14 CET 2012

Nico Huber (nico.huber at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1987


commit e6cd930fc876f1f9cd1003ccb5f646fa04932af4
Author: Nico Huber <nico.huber at secunet.com>
Date:   Fri Dec 7 15:50:40 2012 +0100

    libpayload: Fix use of virtual pointers in sysinfo
    In I4c456f5, I falsely identified struct cb_string.string as a pointer
    which it is not. So we don't need phys_to_virt() here.
    Change-Id: I3e2b6226ae2b0672dfc6e0fa4f6990e14e1b7089
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
 payloads/libpayload/arch/i386/coreboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/arch/i386/coreboot.c b/payloads/libpayload/arch/i386/coreboot.c
index fc22d9a..d39af4a 100644
--- a/payloads/libpayload/arch/i386/coreboot.c
+++ b/payloads/libpayload/arch/i386/coreboot.c
@@ -150,7 +150,7 @@ static void cb_parse_framebuffer(void *ptr, struct sysinfo_t *info)
 static void cb_parse_string(unsigned char *ptr, char **info)
-	*info = (char *)phys_to_virt(((struct cb_string *)ptr)->string);
+	*info = (char *)((struct cb_string *)ptr)->string;
 static int cb_parse_header(void *addr, int len, struct sysinfo_t *info)

More information about the coreboot mailing list