[coreboot] New patch to review for coreboot: e69bbe2 Sandybridge: Temporarily disable MRC cache finding code

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Apr 27 22:59:29 CEST 2012

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/948


commit e69bbe234d907a5d5c2ff4cf52e9d758e106744a
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Fri Apr 27 22:54:10 2012 +0200

    Sandybridge: Temporarily disable MRC cache finding code
    This code is still using libfdt which was denied for inclusion
    in coreboot, so it won't compile as is.
    Without MRC cache, waking from suspend won't work, and cold boots are
    significantly slower (adds around 300-400ms per channel IIRC).
    A rework of this code is currently in the works, but will take a little bit
    more time (and should not hold back the mainboards being merged)
    Change-Id: Ifb9e7d7b86c1f52378803a748810da0d51b58384
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
 src/northbridge/intel/sandybridge/raminit.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 0da968d..dcf9f63 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -121,6 +121,7 @@ static void save_mrc_data(struct pei_data *pei_data)
 static void prepare_mrc_cache(struct pei_data *pei_data)
+#if 0
 	const struct fdt_header *fdt_header;
 	const struct fdt_property *fdtp;
 	int offset, len;
@@ -249,6 +250,9 @@ static void prepare_mrc_cache(struct pei_data *pei_data)
 	printk(BIOS_DEBUG, "%s: at %p, entry %u size %x checksum %04x\n",
 	       __func__, pei_data->mrc_input, entry_id,
 	       pei_data->mrc_input_len, mrc_cache->mrc_checksum);
+	printk(BIOS_ERR, "MRC cache handling code has to be redone.");

More information about the coreboot mailing list