[coreboot] timestamping broke 486 board

Peter Stuge peter at stuge.se
Tue Apr 24 19:02:13 CEST 2012


ron minnich wrote:
> Any chance we can make a config variable called CONFIG_TSC and then
> #error if somebody tries to use a machine that doesn't have it?

There was already a CONFIG_ option for this feature but the code
performing timestamping simply ignored that.

The committed fix solves the problem well.

I think your idea is great in order to protect against similar
problems in the future, if TSC are expected to be used more and more.

All boards except bifferos/bifferboard and emulation/qemu-x86 have

select CPU_

in their Kconfig, so select TSC could be done in the CPU Kconfig
files.


//Peter




More information about the coreboot mailing list