[coreboot] Patch merged into coreboot/master: 1896e2a Make timestamp collection conditional in hardwaremain.c

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 24 18:19:56 CEST 2012

the following patch was just integrated into master:
commit 1896e2a19c848725a30833eabe0f12b10a714527
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Tue Apr 24 16:01:24 2012 +0200

    Make timestamp collection conditional in hardwaremain.c
    Otherwise it breaks 486 boards without RDTSC, ending with
    exception 6.
    It ends like this on bifferboard:
    Jumping to image.
    Unexpected Exception: 6 @ 10:001007e3 - Halting
    Code: 0 eflags: 00000016
    eax: 001001fe ebx: 00100118 ecx: 00000000 edx: 00108e00
    edi: 0010aaf8 esi: 00000000 ebp: 00117ff4 esp: 00117fd8
    Please keep in mind 486, dont use rdtsc/cpuid in generic code, or if you do make sure make it non-default option.
    Change that broke it: http://review.coreboot.org/#/c/749/7/src/boot/hardwaremain.c
    Change-Id: I974b25377c20a11430b35b24dcc275d8cbfd2b9a
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Tue Apr 24 18:19:54 2012, giving +2
See http://review.coreboot.org/925 for details.


More information about the coreboot mailing list