[coreboot] New patch to review for coreboot: d79f893 Revert wbind added to the reset_vector

Marc Jones (marcj303@gmail.com) gerrit at coreboot.org
Fri Apr 20 07:51:42 CEST 2012


Marc Jones (marcj303 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/908

-gerrit

commit d79f893213490c1cb5bbe7c99a4c1aed11435412
Author: Marc Jones <marc.jones at se-eng.com>
Date:   Thu Apr 19 23:44:54 2012 -0600

    Revert wbind added to the reset_vector
    
    This change reverts :
    Change Id I4fdb281b2b684ab5fea999aae28ca08dce24da4d
    
    The wbinvd (or invd) should not be needed at the reset vector. It
    causes problems with some CPUs AP init. If there is a problem with
    a specific CPU and it must be done at this location, it should be
    added conditionally.
    
    Change-Id: I85b71b0a07f039359a4fb889aaa05c75fff619be
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
---
 src/cpu/x86/16bit/reset16.inc |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/cpu/x86/16bit/reset16.inc b/src/cpu/x86/16bit/reset16.inc
index 8dba3c8..1be0e3a 100644
--- a/src/cpu/x86/16bit/reset16.inc
+++ b/src/cpu/x86/16bit/reset16.inc
@@ -2,7 +2,6 @@
 	.code16
 .globl	reset_vector
 reset_vector:
-	wbinvd
 	.byte  0xe9
 	.int   _start - ( . + 2 )
 	/* Note: The above jump is hand coded to work around bugs in binutils.




More information about the coreboot mailing list