[coreboot] New patch to review for coreboot: c036828 ASUS M4A785T-M mainboard: fix screen flickering issues

[Paul Menzel]

Dear Denis,


Am Samstag, den 14.04.2012, 16:00 +0200 schrieb Denis Carikli:

> commit c03682861a1d8716900b74ec3f197faa9a68cecd
> Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
> Date:   Sat Apr 14 14:30:49 2012 +0200
> 
>     ASUS M4A785T-M mainboard: fix screen flickering issues
>     
>     Without that fix the screen flickered with resolutions superior
>       to 832x624 because the cpu_ht_freq was 0 (so it ran at 200Mhz).

could you elaborate more please. Like what you wrote in the IRC channel.
If I am not mistaken you said you copied the code from some other file.

>     Change-Id: I1056d76b1d77f6177594ed9d03ecc5ae7b3c2c13
>     Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
> ---
>  src/mainboard/asus/m4a785-m/romstage.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mainboard/asus/m4a785-m/romstage.c b/src/mainboard/asus/m4a785-m/romstage.c
> index a96592d..870af70 100644
> --- a/src/mainboard/asus/m4a785-m/romstage.c
> +++ b/src/mainboard/asus/m4a785-m/romstage.c
> @@ -246,6 +246,7 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
>   */
>  BOOL AMD_CB_ManualBUIDSwapList (u8 node, u8 link, const u8 **List)
>  {
> +#ifndef CONFIG_BOARD_ASUS_M4A785TM
>  	static const u8 swaplist[] = { 0xFF, CONFIG_HT_CHAIN_UNITID_BASE, CONFIG_HT_CHAIN_END_UNITID_BASE, 0xFF };
>  	/* If the BUID was adjusted in early_ht we need to do the manual override */
>  	if ((CONFIG_HT_CHAIN_UNITID_BASE != 0) && (CONFIG_HT_CHAIN_END_UNITID_BASE != 0)) {
> @@ -255,6 +256,14 @@ BOOL AMD_CB_ManualBUIDSwapList (u8 node, u8 link, const u8 **List)
>  			return 1;
>  		}
>  	}
> +#else
> +	static const u8 swaplist[] = {0, 1, 0xFF, 0, 0xFF};
> +	/* If the BUID was adjusted in early_ht we need to do the manual override */
> +	if ((node == 0) && (link == 0)) {       /* BSP SB link */
> +		*List = swaplist;
> +		return 1;
> +	}
> +#endif
>  
>  	return 0;
>  }

Also why does the ASUS M4A785-m not need this fix?


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20120415/e39d64df/attachment.sig>