[coreboot] New patch to review for coreboot: 42e55bb More portable s3 scratch space creation

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Thu Apr 12 15:05:23 CEST 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/889

-gerrit

commit 42e55bbf332c7c5f137c02c40a124237ebad42fb
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Thu Apr 12 15:03:22 2012 +0200

    More portable s3 scratch space creation
    
    echo -n isn't portable. echo -e isn't portable. that bash loop isn't portable.
    So let's try something else.
    
    Change-Id: Ie73aa1c09d90c11a5c4952a332d4c2058390b5db
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 src/southbridge/amd/Makefile.inc |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/southbridge/amd/Makefile.inc b/src/southbridge/amd/Makefile.inc
index 2cdca29..b4e0982 100644
--- a/src/southbridge/amd/Makefile.inc
+++ b/src/southbridge/amd/Makefile.inc
@@ -17,8 +17,9 @@ subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB900) += cimx
 
 $(obj)/s3.rom:
 	echo "    S3 NVRAM   0xffff0000 (S3 storage area)"
-	echo -ne '\xFF' > $@
-	for ((i=0;i<20479;i++)) do echo -ne '\xFF' >> $@ ; done
+	# create 20480 bytes of 0xff
+	printf '11111111'|sed -e "s,1,11111111,g" -e "s,1,11111111,g" -e "s,1,11111111,g" -e "s,1,11111,g" |tr '1' '\377' > $@.tmp
+	mv $@.tmp $@
 
 ifeq ($(CONFIG_HAVE_ACPI_RESUME), y)
 cbfs-files-y += s3nv




More information about the coreboot mailing list