[coreboot] Patch merged into coreboot/master: 051b64d Force coreboot mconf to create temp files in the output directory

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 2 18:39:24 CEST 2012


the following patch was just integrated into master:
commit 051b64d6dda2a829454e5df752134dcbb0a35ba1
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Mon Oct 24 14:06:23 2011 -0700

    Force coreboot mconf to create temp files in the output directory
    
    This change partially addresses the problem with attempting to
    generate coreboot image out of tree. The configuration step fails when
    in cheroot, if the destination directory is placed in /tmp.
    
    The problem is that the mconf package tries renaming the temporary
    file created in the local directory into the destination config file.
    If the destination root and the local directory are located on
    different file systems, the rename operation fails.
    
    The proper fix (still upcoming) would be to identify all places where
    mconf creates temp files, and make sure that all temp files get
    created in the destination tree.
    
    This change modifies just one location, which prevents building out of
    tree in the most common case.
    
    Test:
      run the following in the coreboot directory in chroot:
        (coreboot) cp config.lumpy .config
        (coreboot) /bin/rm -rf /tmp/cb
        (coreboot) CROSS_COMPILE=i686-pc-linux-gnu- make obj=/tmp/cb oldconfig
        (coreboot) CROSS_COMPILE=i686-pc-linux-gnu- make obj=/tmp/cb
    
      Observe the build succeed (it was failing during the config phase
      before this change)
    
    Change-Id: If4506e984b8afc192a1689c7b0aa956dd35f66c6
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>

Build-Tested: build bot (Jenkins) at Fri Mar 30 21:57:40 2012, giving +1
See http://review.coreboot.org/815 for details.

-gerrit




More information about the coreboot mailing list