[coreboot] New patch to review for coreboot: deb6f0f Add ASUS M5A88-V mainboard support

[Paul Menzel]

Dear Quing Pei,


Am Dienstag, den 06.09.2011, 22:42 +0800 schrieb QingPei Wang:

> i tested by my opensuse 11.2 without X windows.

could you just test if X works please so that nobody wanting to buy that
board gets wrong expectations?

Additionally:

Is suspend/resume working?
Are all ports working (hard drive, USB, …)?
How long does coreboot + payload take on your board to load/initialize?

> the patch is applicable to the former two patches which i sent before.
> And it does not depend on any other patches by AMD at this moment.

Some patches were committed tonight. Could you retest with them please?

> And i am trying to get familiar with gerrit at this moment. I just
> learned how to submit the patches, still does not know how to use "git
> format-patch" things.
> 
> The attachment is a simple boot log with the board. I will cost more time to
> make this better.

A TODO would also be nice. ;-)

> On Tue, Sep 6, 2011 at 10:28 PM, Paul Menzel wrote:

> > Am Dienstag, den 06.09.2011, 15:12 +0200 schrieb QingPei Wang:
> >
> > > commit deb6f0f225bddd2fa786f94689555a21add12d13
> > > Author: QingPei Wang <wangqingpei at gmail.com>
> > > Date:   Tue Sep 6 21:09:40 2011 +0800
> > >
> > >     Add ASUS M5A88-V mainboard support
> > >
> > >     it's a AMD 880+800 mainboard. I port the code
> > >     based on the AMD reference code.

You can use the following Git commands to adapt your patch.

        cd pathtoyourgitcorebootfolder
        
Update the user information (just a suggestion).

        git config --global user.name Quingpei Wang (your Chinese spelling here)
        
Update all remote repositories.

        git fetch

Take a look at the changes.

        git log origin/master # where `origin` is the remote coreboot respository

Checkout your branch with your ASUS M5A88-V stuff.

        git branch # show all local branches
        git checkout m5a88 # substitude m5a88

Put your changes on top of the latest master.

        git rebase origin/master # if there are conflicts, but there should not

Update (amend) the commit message of the last commit to for example add
information, what you have tested.

        git commit --amend -s
        
If you also want to amend files, you have to add the changed file before
amending.

        git add yourfilewithtoamendedchanges
        git add --patch yourfilewithtoamendedchanges # only parts of the
        file
        git commit --amend -s

        git commit -a --amend -s

If you also want to add commits prior to the list one.

        git rebase -i HEAD~8 # number of commits going back

If you need more information the manual pages are also quite good. For
example `git help rebase` opens the manual page for `git rebase`.


Thanks,

Paul


[1] http://review.coreboot.org/#q,status:merged,n,z
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110907/37159798/attachment.sig>