[coreboot] New patch to review: f787a41 Adjust some code/comment of sb700 sata init
Patrick Georgi (patrick@georgi-clan.de)
gerrit at coreboot.org
Sat Sep 3 21:25:29 CEST 2011
Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/186
-gerrit
commit f787a41e3ae338b7d337236b69761dddde2340fe
Author: Wang Qing Pei <wangqingpei at gmail.com>
Date: Tue Nov 9 09:17:07 2010 +0100
Adjust some code/comment of sb700 sata init
The inline comment of sata_init function seems not placed correctly.
Rearrange it.
Change-Id: I63480da60e51cdc68e64c302ad2d8a6197e288f6
Signed-off-by: Wang Qing Pei <wangqingpei at gmail.com>
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
src/southbridge/amd/sb700/sata.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/southbridge/amd/sb700/sata.c b/src/southbridge/amd/sb700/sata.c
index 411baf5..58b72ad 100755
--- a/src/southbridge/amd/sb700/sata.c
+++ b/src/southbridge/amd/sb700/sata.c
@@ -91,14 +91,13 @@ static void sata_init(struct device *dev)
device_t sm_dev;
/* SATA SMBus Disable */
- /* sm_dev = pci_locate_device(PCI_ID(0x1002, 0x4385), 0); */
sm_dev = dev_find_slot(0, PCI_DEVFN(0x14, 0));
- /* Disable SATA SMBUS */
- byte = pci_read_config8(sm_dev, 0xad);
- byte |= (1 << 1);
- /* Enable SATA and power saving */
+
byte = pci_read_config8(sm_dev, 0xad);
+ /* Disable SATA SMBUS */
byte |= (1 << 0);
+ /* Enable SATA and power saving */
+ byte |= (1 << 1);
byte |= (1 << 5);
pci_write_config8(sm_dev, 0xad, byte);
More information about the coreboot
mailing list