[coreboot] New patch to review for coreboot: d1f0250 Fix CMOS checksum calculation in libpayload.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Oct 21 23:38:34 CEST 2011


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/314

-gerrit

commit d1f0250388d73127f4db35d03d2b3753d1e6b552
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Fri Oct 21 14:37:52 2011 -0700

    Fix CMOS checksum calculation in libpayload.
    
    Change-Id: I64ea53fa098fbcfc76e0ebd5f049a2ee3d0a1024
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 payloads/libpayload/drivers/options.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c
index fdb4be3..394c792 100644
--- a/payloads/libpayload/drivers/options.c
+++ b/payloads/libpayload/drivers/options.c
@@ -41,7 +41,6 @@ static int options_checksum_valid(void)
 	for(i = range_start; i <= range_end; i++) {
 		checksum += nvram_read(i);
 	}
-	checksum = (~checksum)&0xffff;
 
 	checksum_old = ((nvram_read(checksum_location)<<8) | nvram_read(checksum_location+1));
 
@@ -59,7 +58,6 @@ void fix_options_checksum(void)
 	for(i = range_start; i <= range_end; i++) {
 		checksum += nvram_read(i);
 	}
-	checksum = (~checksum)&0xffff;
 
 	nvram_write((checksum >> 8), checksum_location);
 	nvram_write((checksum & 0xff), checksum_location + 1);




More information about the coreboot mailing list