[coreboot] New patch to review for coreboot: 63c55f8 libpayload: fix bulk transfers on OHCI controllers

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Fri Oct 21 15:46:35 CEST 2011

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/306


commit 63c55f820611f3e46f6323d6b22ede3444a6d039
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Fri Oct 21 15:45:09 2011 +0200

    libpayload: fix bulk transfers on OHCI controllers
    Time for the brown paper bag: OHCI controllers are not happy when
    told to send data, but with obviously wrong addresses. It helps
    to write the addresses into the data structures.
    Change-Id: Ic0967dc8939e64af119cfb89400a045a2c077171
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
 payloads/libpayload/drivers/usb/ohci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c
index 94c1945..290f782 100644
--- a/payloads/libpayload/drivers/usb/ohci.c
+++ b/payloads/libpayload/drivers/usb/ohci.c
@@ -384,6 +384,7 @@ ohci_bulk (endpoint_t *ep, int dalen, u8 *data, int finalize)
 		cur->delay_interrupt = 7;
 		cur->condition_code = 0xf;
 		cur->direction = (ep->direction==IN)?OHCI_IN:OHCI_OUT;
+		cur->current_buffer_pointer = virt_to_phys(data);
 		if (dalen == 0) {
 			/* magic TD for empty packet transfer */

More information about the coreboot mailing list