[coreboot] New patch to review for coreboot: 9dcc23d w83627hf: add method to retrive wake event source register to ASL include

Christoph Grenz christophg+cb at grenz-bonn.de
Wed Oct 19 15:22:06 CEST 2011

Hello Paul,

Am Mittwoch, 19. Oktober 2011, um 10:08:07 schrieb Paul Menzel:
> Dear Christoph,
> [...] 
> >     Add a method WAKS to devtree.asl which returns the wake-up status
> >     register
> Should it be »wake-up *source* register«? The data sheet [1] calls it
> »CRE3 (Read only) Keyboard/Mouse Wake-Up Status register« but source
> seems to be a better description as you also used it in the code.
> I send this message because I got confused by all the different names
> for the same register, if I am not mistaken.

Yes, I mixed my own naming (as *source* register really fits better) and the 
one from the data sheet. I think I'll change it everywhere to "wake-up source 

> >     to simplify retrieving the wake source e.g. in \_WAK.
> >     
> >     Change-Id: Ia258f8fc9ff79b18391c55464da73863889e2255
> >     Signed-off-by: Christoph Grenz <christophg+cb at grenz-bonn.de>
> > 
> > ---
> > 
> [...]
> Otherwise I do not know ASL, but I guess you tested that, so it looks
> good to me.

Yeah, I copy-pasted it to my mainboards original DSDT and iasl, acpiexec and 
the linux kernel were happy with it.

> Thanks,
> Paul
> [1] http://www.itox.com/pages/support/wdt/W83627HF.pdf

More information about the coreboot mailing list