[coreboot] New patch to review for coreboot: 6a8e422 cbfs_and_run_core() is not part of the API, make it static.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sat Oct 15 00:27:01 CEST 2011

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/273


commit 6a8e4225befd6f6a6e035e628cb5e12b2b23bffc
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Fri Oct 14 14:50:19 2011 -0700

    cbfs_and_run_core() is not part of the API, make it static.
    It's only used in cbfs_and_run.c
    Change-Id: Ibcfcefbeb0c5722eb3888f0d60127229a2badcf6
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
 src/arch/x86/include/arch/stages.h |    1 -
 src/arch/x86/lib/cbfs_and_run.c    |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/include/arch/stages.h b/src/arch/x86/include/arch/stages.h
index 00d2a93..3ddba51 100644
--- a/src/arch/x86/include/arch/stages.h
+++ b/src/arch/x86/include/arch/stages.h
@@ -19,7 +19,6 @@
 #ifndef __ARCH_STAGES_H
 #define __ARCH_STAGES_H
-void cbfs_and_run_core(const char *filename, unsigned int ebp);
 void __attribute__((regparm(0))) copy_and_run(unsigned cpu_reset);
 void __attribute__((regparm(0))) copy_and_run_ap_code_in_car(unsigned ret_addr);
diff --git a/src/arch/x86/lib/cbfs_and_run.c b/src/arch/x86/lib/cbfs_and_run.c
index 5e3d8fe..ad36ddc 100644
--- a/src/arch/x86/lib/cbfs_and_run.c
+++ b/src/arch/x86/lib/cbfs_and_run.c
@@ -21,7 +21,7 @@
 #include <cbfs.h>
 #include <arch/stages.h>
-void cbfs_and_run_core(const char *filename, unsigned ebp)
+static void cbfs_and_run_core(const char *filename, unsigned ebp)
 	u8 *dst;

More information about the coreboot mailing list