[coreboot] New patch to review for coreboot: 9570367 Prevent build breakage without consoles enabled
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Thu Oct 13 00:49:00 CEST 2011
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/260
-gerrit
commit 957036708c6ce1396fc1ebbf33e3e3a01af09bc7
Author: Stefan Reinauer <reinauer at chromium.org>
Date: Wed Jun 1 14:04:50 2011 -0700
Prevent build breakage without consoles enabled
If all console types are disabled, coreboot will fail to compile because
static code is unused. This patch fixes the issue.
Signed-off-by: Stefan Reinauer <reinauer at google.com>
Change-Id: Ie9c8bf2a78e3aeba4c2908b06bc03f0f5af37db2
---
src/arch/x86/boot/coreboot_table.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/arch/x86/boot/coreboot_table.c b/src/arch/x86/boot/coreboot_table.c
index d53a23a..cdfc0c1 100644
--- a/src/arch/x86/boot/coreboot_table.c
+++ b/src/arch/x86/boot/coreboot_table.c
@@ -120,6 +120,8 @@ static struct lb_serial *lb_serial(struct lb_header *header)
#endif
}
+#if CONFIG_CONSOLE_SERIAL8250 || CONFIG_CONSOLE_SERIAL8250MEM || \
+ CONFIG_CONSOLE_LOGBUF || CONFIG_USBDEBUG
static void add_console(struct lb_header *header, u16 consoletype)
{
struct lb_console *console;
@@ -130,6 +132,8 @@ static void add_console(struct lb_header *header, u16 consoletype)
console->type = consoletype;
}
+#endif
+
static void lb_console(struct lb_header *header)
{
#if CONFIG_CONSOLE_SERIAL8250
More information about the coreboot
mailing list