[coreboot] Patch set updated for coreboot: 42acf3c mainboard: complete the sb800 devicetree even device is off

Kerry Sheh (shekairui@gmail.com) gerrit at coreboot.org
Mon Oct 10 12:55:34 CEST 2011


Kerry Sheh (shekairui at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/230

-gerrit

commit 42acf3ccf042ecf596df8d149ad66512e81a8fc8
Author: Kerry Sheh <shekairui at gmail.com>
Date:   Mon Oct 10 19:19:46 2011 +0800

    mainboard: complete the sb800 devicetree even device is off
    
    sb800 cimx entry sb_Before_Pci_Init was called in the device 16.2
    enable_dev() function. If the devicetree don't have this device,
    then sb_Before_Pci_Init will not get called.
    
    Change-Id: I76ebad842e90b0f740abbec031165d7c39a80abf
    Signed-off-by: Kerry Sheh <kerry.she at amd.com>
    Signed-off-by: Kerry Sheh <shekairui at gmail.com>
---
 src/mainboard/amd/inagua/devicetree.cb    |    2 ++
 src/mainboard/asrock/e350m1/devicetree.cb |    2 ++
 src/southbridge/amd/cimx/sb800/late.c     |    4 +++-
 3 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/src/mainboard/amd/inagua/devicetree.cb b/src/mainboard/amd/inagua/devicetree.cb
index 82658cf..32d9a26 100644
--- a/src/mainboard/amd/inagua/devicetree.cb
+++ b/src/mainboard/amd/inagua/devicetree.cb
@@ -71,6 +71,8 @@ chip northbridge/amd/agesa/family14/root_complex
 					device pci 15.1 on end # PCIe PortB
 					device pci 15.2 on end # PCIe PortC
 					device pci 15.3 on end # PCIe PortD
+					device pci 16.0 off end # OHCI USB3
+					device pci 16.2 off end # EHCI USB3
 					register "gpp_configuration" = "4" #1:1:1:1
 		  			register "boot_switch_sata_ide" = "0"	# 0: boot from SATA. 1: IDE
 				end	#southbridge/amd/cimx/sb800
diff --git a/src/mainboard/asrock/e350m1/devicetree.cb b/src/mainboard/asrock/e350m1/devicetree.cb
index bff8151..ca5cf2b 100644
--- a/src/mainboard/asrock/e350m1/devicetree.cb
+++ b/src/mainboard/asrock/e350m1/devicetree.cb
@@ -103,6 +103,8 @@ chip northbridge/amd/agesa/family14/root_complex
 					device pci 15.1 on  end # PCIe PortB: NIC
 					device pci 15.2 on  end # PCIe PortC: USB3
 					device pci 15.3 off end # PCIe PortD
+					device pci 16.0 off end # OHCI USB3
+					device pci 16.2 off end # EHCI USB3
 
 					# gpp_configuration options
 					#0000: PortA lanes[3:0]
diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c
index b581212..c36ee03 100644
--- a/src/southbridge/amd/cimx/sb800/late.c
+++ b/src/southbridge/amd/cimx/sb800/late.c
@@ -419,7 +419,9 @@ static void sb800_enable(device_t dev)
 	case (0x16 << 3) | 2: /* 0:16:2 EHCI-USB3 */
 		sb_config->USBMODE.UsbMode.Ehci3 = dev->enabled;
 
-		/* the last sb800 device */
+		/* call the CIMX entry at the last sb800 device,
+		 * so make sure the mainboard devicetree is complete
+		 */
 		sb_Before_Pci_Init();
 		break;
 




More information about the coreboot mailing list