[coreboot] New patch to review for coreboot: 0ac8b94 Fix post_code in 16bit entry

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Mon Nov 21 22:47:33 CET 2011


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/439

-gerrit

commit 0ac8b94d07a5b2f4f8bced6f17c44816f79c5b55
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Nov 21 08:16:20 2011 +0200

    Fix post_code in 16bit entry
    
    Relocate early post_code() so it gets executed and does not corrupt
    BIST at %eax.
    
    Change-Id: Ieeebcb23f7c327e501b410eaa60d1e49110ee988
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/arch/x86/init/prologue.inc |    4 ----
 src/cpu/x86/16bit/entry16.inc  |    2 ++
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/arch/x86/init/prologue.inc b/src/arch/x86/init/prologue.inc
index b85c5c0..84e465c 100644
--- a/src/arch/x86/init/prologue.inc
+++ b/src/arch/x86/init/prologue.inc
@@ -23,7 +23,3 @@
 .section ".rom.data", "a", @progbits
 .section ".rom.text", "ax", @progbits
 
-/* This is the entry code. The code in the .reset section jumps here. */
-
-	post_code(POST_RESET_VECTOR_CORRECT)
-
diff --git a/src/cpu/x86/16bit/entry16.inc b/src/cpu/x86/16bit/entry16.inc
index 9f4c0e3..9b7b69c 100644
--- a/src/cpu/x86/16bit/entry16.inc
+++ b/src/cpu/x86/16bit/entry16.inc
@@ -36,6 +36,8 @@ _start:
 	/* Save the BIST result */
 	movl	%eax, %ebp
 
+	post_code(POST_RESET_VECTOR_CORRECT)
+
 /* thanks to kmliu at sis.tw.com for this TBL fix ... */
 /**/
 /* IMMEDIATELY invalidate the translation lookaside buffer before executing*/




More information about the coreboot mailing list