[coreboot] Keyboard not working on Thinkpad X60/T60

[Kevin O'Connor]

On Sat, May 28, 2011 at 04:23:35PM +0200, Sven Schnelle wrote:
> Kevin O'Connor <kevin at koconnor.net> writes:
> > On Sat, May 07, 2011 at 08:48:45PM +0200, Sven Schnelle wrote:
> >> Kevin O'Connor <kevin at koconnor.net> writes:
> >> > Some ps2 ports send NAK (0xfe) when there is no keyboard plugged in.
> >> > The detection for NAK was added so that it doesn't take a full second
> >> > to recognize that no keyboard is present.  The patch you sent would
> >> > loop infinitely in this situation.
> >> 
> >> Yes, the patch was only for testing purposes. :)
> >> 
> >> I feared that are controllers out there that behave like this, so i have
> >> to find another solution.
> >
> > How about something like (untested):
[...]
> > If it works, the 4000 could be turned into a config option.
> 
> Yes, that fixes it. I'm using the patch below right now.

Thanks.  I committed a similar patch.

> Not sure about the default value, but 0 seems to be safe to not
> introduce an additional delay for other users ;)

Yeah - using zero as the default should make this a nop for other
users.

-Kevin