[coreboot] [patch] ck804 mmconf
stefan.reinauer at coreboot.org
Sun May 22 23:55:58 CEST 2011
On 5/22/11 1:07 PM, Jonathan A. Kollasch wrote:
> On Sun, May 22, 2011 at 12:28:41PM -0700, Stefan Reinauer wrote:
>> On 5/22/11 8:12 AM, Jonathan A. Kollasch wrote:
>>> Optionally treat ck804 memory-mapped PCI configuration space window as a
>>> resource. Not enabled by default because the resource should be
>>> non-posted and there's no way to express that to the resource allocator.
>>> Signed-off-by: Jonathan Kollasch<jakllsch at kollasch.net>
>> Please don't make stuff like that a Kconfig option. All memory used
>> by devices should be resources, so it's fine to always enable this,
>> given that it's tested and works.
> Aren't there fam10h boards that have a ck804 southbridge?
> How do we make sure the appropriate mmconf implementation is used?
We have defines for the cpu/northbridge/southbridge already ... why not
use those, if needed?
>> Why would the resource allocator have to worry about posted vs
>> non-posted PCI transactions?
> How else will the northbridge be told to make the region non-posted?
Why would it have to? Not sure I understand your concern. Your patch
does not address that issue at all.
More information about the coreboot