[coreboot] [commit] r6608 - trunk/src/southbridge/nvidia/ck804

[Stefan Reinauer]

On 5/22/11 1:02 PM, Jonathan A. Kollasch wrote:
> On Sun, May 22, 2011 at 12:25:37PM -0700, Stefan Reinauer wrote:
>> On 5/22/11 8:39 AM, repository service wrote:
>>> Author: jakllsch
>>> Date: Sun May 22 17:39:25 2011
>>> New Revision: 6608
>>> URL: https://tracker.coreboot.org/trac/coreboot/changeset/6608
>>>
>>> Log:
>>> Ensure ck804 romstrap is 16-byte aligned.
>>> This alignment seems to be necessary for the chip to recognize it.
>>>
>>> Signed-off-by: Jonathan Kollasch<jakllsch at kollasch.net>
>>> Acked-by: Jonathan Kollasch<jakllsch at kollasch.net>
>>>
>>> Modified:
>>>     trunk/src/southbridge/nvidia/ck804/romstrap.inc
>>>
>>> Modified: trunk/src/southbridge/nvidia/ck804/romstrap.inc
>>> ==============================================================================
>>> --- trunk/src/southbridge/nvidia/ck804/romstrap.inc	Sun May 22 00:18:59 2011	(r6607)
>>> +++ trunk/src/southbridge/nvidia/ck804/romstrap.inc	Sun May 22 17:39:25 2011	(r6608)
>>> @@ -21,6 +21,7 @@
>>>   	.section ".romstrap", "a", @progbits
>>>
>>>
>>> +	.align 4
>> Shouldn't this be .align 16 then?
> The as(1) info page says it's in bits on x86.
>
> 	Jonathan Kollasch
>
Oh does it? This used to be only the case for i386 + a.out. It seems at 
least the coreboot reference compiler assumes those are bytes.