[coreboot] [commit] r6578 - in trunk/src: mainboard/amd/persimmon northbridge/amd/agesa_wrapper/family14 vendorcode/amd/cimx/sb800

[Marc Jones]

On Sun, May 15, 2011 at 4:51 PM, Peter Stuge <peter at stuge.se> wrote:
> repository service wrote:
>> Move mmconf base from e0000000 to f8000000
> ..
>> +++ trunk/src/mainboard/amd/persimmon/dsdt.asl        Sun May 15 23:26:04 2011        (r6578)
>> @@ -36,7 +36,7 @@
>>       Name(PBAD, 0x0) /* Address of BIOS area (If TOM2 != 0, Addr >> 16) */
>>       Name(PBLN, 0x0) /* Length of BIOS area */
>>
>> -     Name(PCBA, 0xE0000000)  /* Base address of PCIe config space */
>> +     Name(PCBA, 0xF8000000)  /* Base address of PCIe config space */
>>       Name(HPBA, 0xFED00000)  /* Base address of HPET table */
> ..
>
>> +++ trunk/src/northbridge/amd/agesa_wrapper/family14/Kconfig  Sun May 15 23:26:04 2011        (r6578)
>> @@ -41,12 +41,12 @@
>>
>>  config MMCONF_BASE_ADDRESS
>>       hex
>> -     default 0xe0000000
>> +     default 0xf8000000
> ..
>
>> +++ trunk/src/vendorcode/amd/cimx/sb800/OEM.h Sun May 15 23:26:04 2011        (r6578)
>> @@ -48,7 +48,7 @@
>>  #ifdef  MOVE_PCIEBAR_TO_F0000000
>>    #define PCIEX_BASE_ADDRESS           0xF7000000
>>  #else
>> -  #define PCIEX_BASE_ADDRESS           0xE0000000
>> +  #define PCIEX_BASE_ADDRESS           0xF8000000
>
> Magic numbers. Nomnom! Can we at the very least get away from the
> duplication?
>
>
> //Peter

sounds good.

r6596


-- 
http://se-eng.com