[coreboot] [PATCHes] Adopt coreboot build system for libpayload

Patrick Georgi patrick at georgi-clan.de
Wed May 11 08:47:33 CEST 2011


Am 10.05.2011 22:19, schrieb Stefan Reinauer:
> * Patrick Georgi <patrick at georgi-clan.de> [110510 21:24]:
>> -## modification, are permitted provided that the following conditions
> Hm... can we relicense this under the original license instead? I
> dislike going to GPL in an otherwise cleanly BSD license based project.
> The coresystems written parts may certainly be relicensed under BSD. Not
> sure how much except the header is actually left from AMD and co.
Most of it is by Ron, you and I. (as taken from svn annotate which isn't
entirely accurate, but gives a good estimate).
But things in Makefile are either rather trivial or ours, as all the
coreboot/libpayload specific rules were moved to Makefile.inc.

>> +config MEMMAP_RAM_ONLY
> Is this needed for reducing the warnings? What else is it needed for?
We had this ad-hoc config option in the code, so I made it selectable.
Maybe we should get rid of that option altogether?

>>  struct layout_maps {
>> -	char *country;
>> +	const char *country;
>>  	unsigned short map[4][0x57];
> can the map be const, too?
yes.

>> +static char *invalid_pci_device_string = (char*)"invalid pci device string";
> minor nitpick, i think this should be (char *), like char *invalid_....
> earlier in the line. And maybe it can be const?
It's an ugly hack to work around libpci API requirements, which is why
it is non-const.

>> Add strlcpy from OpenBSD
>> Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
> This one is
> Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Thanks, but it depends (in this version) on the other patches (build
system hookup)


Patrick




More information about the coreboot mailing list