[coreboot] [PATCH] Replace the values of APIC timer init with macros
scott at notabs.org
Wed May 11 01:41:37 CEST 2011
Vikram Narayanan wrote:
]On Sun, 2011-05-08 at 00:34 +0530, Vikram Narayanan wrote:
]> This replaces the fixed shift values in the apic timer init with macros.
]> Signed-off by: Vikram Narayanan <vikram186 at gmail.com>
]> --- a/src/cpu/x86/lapic/apic_timer.c Sun May 8 00:18:12 2011
]> +++ b/src/cpu/x86/lapic/apic_timer.c Sun May 8 00:08:54 2011
]> @@ -36,7 +36,7 @@
]> msr_t fsb_clock_sts;
]> /* Set the apic timer to no interrupts and periodic mode */
]> - lapic_write(LAPIC_LVTT, (1 << 17) | (1<< 16) | (0 << 12) | (0 <<
]> + lapic_write(LAPIC_LVTT, (LAPIC_LVT_TIMER_PERIODIC |
]> /* Set the divider to 1, no divider */
]> lapic_write(LAPIC_TDCR, LAPIC_TDR_DIV_1);
]Think this is quite trivial. Can someone comment on this so that this
]will be merged in the next commit?
It looks OK to me, though there is an unneeded pair of parentheses.
acked by: Scott Duplichan <scott at notabs.org>
More information about the coreboot