[coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

Patrick Georgi patrick at georgi-clan.de
Tue May 10 23:55:49 CEST 2011


Am 10.05.2011 22:07, schrieb Stefan Reinauer:
>> Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
> Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
r6565, thanks.

>>  15 files changed, 24 insertions(+), 23 deletions(-)
> Wow are those the only occurences of readoption in romstage code?
read_option is used in romstage, get_option in ramstage. The latter
doesn't provide an option for default values.
I intend to change that once we declare defaults in cmos.layout (or its
successor), so the romstage gets the defaults from the same source.

But yes, there aren't any more read_option uses. Probably a sign that
the nvram subsystem is underused?

> Should we document that somewhere? 
Document what?


Patrick




More information about the coreboot mailing list