[coreboot] [patch] correct off-by-one in pre-rev-F model F powernow code

Jonathan A. Kollasch jakllsch at kollasch.net
Thu Mar 3 23:13:56 CET 2011


Correct off-by-one problem in AMD pre-rev-F model-F PowerNow code.
With this change the last P-state entry of the last CPU in the table
is successfully conveyed into the SSDT.

Signed-off-by: Jonathan Kollasch <jakllsch at kollasch.net>
----
-------------- next part --------------
Index: src/cpu/amd/model_fxx/powernow_acpi.c
===================================================================
--- src/cpu/amd/model_fxx/powernow_acpi.c	(revision 6429)
+++ src/cpu/amd/model_fxx/powernow_acpi.c	(working copy)
@@ -622,7 +622,7 @@
 		Pstate_vid[Pstate_num] = vid_to_reg(data->pstates[Pstate_num - 1].voltage);
 		Pstate_power[Pstate_num] = data->pstates[Pstate_num - 1].tdp * 100;
 		Pstate_num++;
-	} while ((Pstate_num < MAXP) && (data->pstates[Pstate_num].freqMhz != 0));
+	} while ((Pstate_num < MAXP) && (data->pstates[Pstate_num - 1].freqMhz != 0));
 
 	for (i=0;i<Pstate_num;i++)
 		printk(BIOS_DEBUG, "P#%d freq %d [MHz] voltage %d [mV] TDP %d [mW]\n", i,


More information about the coreboot mailing list