[coreboot] [PATCH] [sort of] multiplex console output from each core

xdrudis xdrudis at tinet.cat
Sun Jan 30 22:06:01 CET 2011


On Sun, Jan 30, 2011 at 09:07:52PM +0100, Stefan Reinauer wrote:
> * xdrudis <xdrudis at tinet.cat> [110130 20:59]:
> > Yes, it'd be mostly unneeded, but anyway the patch I sent does not 
> > disable it in ramstage. So it still causes sprintf to consume 
> > the double of bytes maybe beyond its buffers (and produce 
> > unreadable messages). The idea can work, the perl script may be
> > usable, but the patches to C should be redone from scratch. 
> 
> Can't you just hack up the muxing in console_tx_byte instead? That
> should solvle the problem and make the patch a tad less intrusive.
> 

yes, console_tx_byte or __console_tx_byte .

The only drawback is that then I have to call calc_id_buffer for 
each byte, I guess it doesn't matter, but it was less overhead 
calling it once per call to  vtxprintf (in fact there was another 
call in number(...) but still fewer than one per byte.


But I just got past fidvid now, and I should clean up the mess of code
I've been changing all these months and see what exactly fixed it, or
if I can have a decent patch.  Not sure it'll be much help for other
CPU revisions beyond C3, though.






More information about the coreboot mailing list