[coreboot] [PATCH]Use cbfs-files-y for normal file additions

Peter Stuge peter at stuge.se
Sat Jan 29 11:22:50 CET 2011

Georgi, Patrick wrote:
> Question is, if we should drop these Kconfig options entirely and let
> the user handle these entries in the board's Makefile.inc?

Sometimes the files come from chipset though.

> Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>

With the fix below:

Acked-by: Peter Stuge <peter at stuge.se>

> +++ b/src/arch/x86/Makefile.inc
> @@ -117,6 +96,18 @@ endif
>  	@printf "    CBFSPRINT  $(subst $(obj)/,,$(@))\n\n"
>  	$(CBFSTOOL) $@ print
> +cbfs-files-$(CONFIG_VGA_BIOS) += pci$(call strip_quotes,$(CONFIG_VGA_BIOS_ID)).rom
> +pci$(CONFIG_VGA_BIOS_ID)-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE))
> +pci$(CONFIG_VGA_BIOS_ID)-type := optionrom

These last two need .rom as well, right?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110129/6b840a01/attachment.sig>

More information about the coreboot mailing list