[coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Stefan Reinauer reinauer at google.com
Sat Jan 29 00:03:32 CET 2011


Hi Alexandru,

thanks for finding this issue. I think I ran into this before. We
should not silently continue in this case, and not create a resource
either. The problem is most likely caused by a faulty devicetree.cb or
superio driver. Hence, I suggest to print an error instead. See patch.
Can you test, please? It should tell you which device / index is
causing the problem.

Stefan

On Fri, Jan 28, 2011 at 2:14 AM, Alex G. <mr.nuke.me at gmail.com> wrote:
> Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if
> a rare condition arises.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
> ---
>
>
> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>



-- 
Stefan Reinauer
Google Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: catch_endless_loop.diff
Type: text/x-patch
Size: 735 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110128/ca15273d/attachment.diff>


More information about the coreboot mailing list