[coreboot] [PATCH]Sanitize cbfs-files-y
stefan.reinauer at coreboot.org
Fri Jan 28 22:02:50 CET 2011
* Georgi, Patrick <Patrick.Georgi at secunet.com> [110128 15:32]:
> attached patch inverses two arguments of cbfs-files-y and adapts its
> users (one of which already used the new order). This is in reponse to
> feedback that the original setup was too complicated.
> New cbfs-files-y:
> cbfs-files-y contains the names of files as they appear in CBFS. The
> arguments describe the on-filesystem name, the type and (optionally) the
> position. Example:
> cbfs-files-y += foo
> foo-file := bar
> foo-type := splashscreen
> foo-position := 0xffff8000
Stuff like cmos.layout could arguably go into fallback/ or normal/.
What's the right way to solve this with cbfs-files-y?
If it stays in /, what happens if an image is updated with a newer
version of cmos.layout (say, no old options move/remove so it's safe in
that regard). Will the file be ignored? Or Overwritten? Do we produce a
proper warning for that?
More information about the coreboot