[coreboot] [PATCH] rs780 PCIE GFX core add pcie ddi config option

[Marc Jones]

On Wed, Jan 26, 2011 at 8:22 PM, She, Kerry <Kerry.She at amd.com> wrote:
> Hello,
>
> This patch add pcie and ddi configuration option for rs780 PCIE GFX core.
>
> Reference rpr chapter 7.
>
> thanks
>
>
>
> signed-off-by: Kerry she <kerry.she at amd.com>

Hi Kerry,

> +#if 0 // use the default value
> 	set_nbmisc_enable_bits(nb_dev, 0x28, 3 << 6 | 3 << 8 | 3 << 10,
> 			       1 << 6 | 1 << 8 | 1 << 10);
>+#endif

Remove that code if it isn't needed. Don't leave #if0 when possible.

With that removed,
Acked-by: Marc Jones <marcj303 at gmail.com>


You added new config options, is there another patch for the mainboards?


Marc


-- 
http://se-eng.com