[coreboot] [PATCH] get USB debug console working in ROM stage

Georgi, Patrick Patrick.Georgi at secunet.com
Fri Jan 28 08:22:33 CET 2011


Am Donnerstag, den 27.01.2011, 18:16 -0800 schrieb Stefan Reinauer:
> +#if defined(__ROMCC__)
> +#define printk(BIOS_DEBUG, fmt, arg...)   do {} while(0)
> +#else 
romcc doesn't support variadic macros. This only "works" because no
chipset that uses romcc supports USB debug.
Given the age of romcc-chipsets I think it's safe to assume that they
support serial console, so how about we make usbdebug a CAR-only feature
(ie. drop this #define)?

Otherwise the patch is
Acked-by: Patrick Georgi <patrick.georgi at secunet.com>


Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110128/4df0d213/attachment.sig>


More information about the coreboot mailing list