[coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

Georgi, Patrick Patrick.Georgi at secunet.com
Tue Jan 25 13:54:01 CET 2011

Am Dienstag, den 25.01.2011, 13:24 +0100 schrieb Georgi, Patrick:
> I'm not quite sure if using weak functions to wrap the subsystem
> CONFIG_* values is actually the right approach, I'll work on a patch to
> discuss.
Here it is.
I tested it by providing a mainboard_pci_subsystem_vendor_id for my
board in its mainboard.c which returned a different constant value -
this was picked up by properly and reported on boot.
mainboard_pci_subsystem_device_id will work just the same.

Joseph, will this suffice to help you implement your requirement?

Everyone, any opinion on the design?
My main issue is that other code can still use the CONFIG_* values
directly. Maybe our lint mechanism should look for that?
Any other issues you have with this?

Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: overridable-subsys-subdev-ids.diff
Type: text/x-patch
Size: 2816 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110125/48554088/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110125/48554088/attachment.sig>

More information about the coreboot mailing list