[coreboot] [PATCH] Add new ec subdir for Embedded Controllers

Stefan Reinauer stefan.reinauer at coreboot.org
Wed Jan 19 08:34:06 CET 2011


* Peter Stuge <peter at stuge.se> [110119 07:55]:
> Sven Schnelle wrote:
> > +++ src/ec/acpi/Makefile.inc	(revision 0)
> > @@ -0,0 +1 @@
> > +driver-y += ec.c
> 
> ..
> 
> > +++ src/mainboard/roda/rk886ex/Makefile.inc	(working copy)
> > @@ -18,7 +18,6 @@
> >  ##
> >  
> >  ramstage-y += m3885.c
> > -ramstage-y += ec.c
> >  driver-y += rtl8168.c
> >  
> >  smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
> 
> I think it should be ramstage-y also in ec/acpi/Makefile.inc no?
 
Yes, I think so too. In theory, unused objects in ramstage are kicked
out, while in drivers they are not. Maybe with a smart generation of gcc
and binutils evolving, we can get rid of this size "hack" and treat
everything in ram stage the same way, while LTO keeps the image small
for us.
I did some tests with LTO and 4.5.0, and the resulting images were not
bootable. However, I think since then a lot of bugs have been fixed. So
maybe someone wants to try?

Stefan




More information about the coreboot mailing list