[coreboot] [PATCH]Move option table to CBFS

Patrick Georgi Patrick.Georgi at secunet.com
Tue Jan 18 15:40:18 CET 2011


Am Dienstag, den 18.01.2011, 15:22 +0100 schrieb Mathias Krause:
> Well, but after the build the CBFS could still be modified (intentional
> or not) in such a way that it would no longer contain a file named
> "cmos_layout.bin". So at least to aid debugging it would be nice to see
> a warning here instead of wondering why the CMOS layout is missing in
> the LB table.
I added some reporting in r6269.

> I guess you assume it'll return either 1 (good case) or 0 (bad case) not
> -1 - which is the case btw. But you're right. I mixed up the size and
> count parameters of the fwrite() call. So you check is fine the way it is.
r6270 makes this more explicit for all calls (so return -E* bails out,
too).


Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110118/b2b840a6/attachment.sig>


More information about the coreboot mailing list