[coreboot] Initial bits to support Thinkpad X60

Peter Stuge peter at stuge.se
Mon Jan 10 21:34:13 CET 2011

Nice, a ThinkPad patch! :) Many have wanted that.

Sven Schnelle wrote:
> commit 7d3a1ebf3de5746d3dec8f47e74458c15018c694
> Author: Sven Schnelle <svens at stackframe.org>
> Date:   Mon Jan 10 13:23:59 2011 +0100
>     Initial bits for X60 support
>     Signed-off-by: Sven Schnelle <svens at stackframe.org>

Well the commit is quite a lot more than initial bits for support. :)

Could you split this up in a few more commits? E.g. one that adds the
CPU model to the socket, one for speedstep (maybe combine them if
appropriate) and then the one that adds the new board?

Also, in particular for the patch that adds the new board, it is
quite beneficial to use svn cp to copy files and *then* modify them
for the new boards - that way the history is kept and the patch is
much easier to look at. I am not sure how well git svn supports these
operations. Maybe it does, but I haven't tried it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110110/71d630e9/attachment.sig>

More information about the coreboot mailing list