[coreboot] [PATCH] disabling microcode update

[xdrudis]

On Sat, Feb 26, 2011 at 03:53:43AM +0200, Alex G. wrote:
> On 02/26/2011 03:39 AM, xdrudis wrote:
> > This patch tries to fix compilation when you select EXPERT in make menuconfig.
> > 
> HT Frequencies are multiples of 200MHz AFAIK, so there are no 300MHz and
> 500MHz. I'm not sure why the build breaks, and why this fixes it, but I
> don't think this is the right solution.
> Someone wiser should comment on this.
> 

Oh! You may well be right. All others are multiples of 200 MHz .

Then we should maybe remove 2 #elif in the following code. But I wonder 
whether the break in the progression of values indicates that
all values from there on should be changed too.

I have no idea what this does, other than the Kconfig help:

   choice
	prompt "HyperTransport frequency"
	default LIMIT_HT_SPEED_AUTO
	help
	  This option sets the maximum permissible HyperTransport link
	  frequency.

	  Use of this option will only limit the autodetected HT frequency.
	  It will not (and cannot) increase the frequency beyond the
	  autodetected limits.

	  This is primarily used to work around poorly designed or laid out
	  HT traces on certain motherboards.

The code where it is used is in 
src/northbridge/amd/amdht/h3finit.c:1330

#if CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_200
    		  cbPCBFreqLimit = 0x0001;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_300
      		    cbPCBFreqLimit = 0x0003;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_400
      		    cbPCBFreqLimit = 0x0007;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_500
      		    cbPCBFreqLimit = 0x000F;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_600
      		    cbPCBFreqLimit = 0x001F;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_800
      		    cbPCBFreqLimit = 0x003F;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_1000
      		    cbPCBFreqLimit = 0x007F;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_1200
      		    cbPCBFreqLimit = 0x00FF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_1400
      		    cbPCBFreqLimit = 0x01FF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_1600
      		    cbPCBFreqLimit = 0x03FF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_1800
      		    cbPCBFreqLimit = 0x07FF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_2000
      		    cbPCBFreqLimit = 0x0FFF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_2200
      		    cbPCBFreqLimit = 0x1FFF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_2400
      		    cbPCBFreqLimit = 0x3FFF;
#elif CONFIG_EXPERT && CONFIG_LIMIT_HT_SPEED_2600
      		    cbPCBFreqLimit = 0x7FFF;
#else
		cbPCBFreqLimit = 0xFFFF;		// Maximum allowed by autoconfiguration
#endif