[coreboot] [PATCH] outb(* 0x80) to post_code()

Alex G. mr.nuke.me at gmail.com
Fri Feb 25 23:26:19 CET 2011


Hi Stefan and Patrick. I Just saw your emails.

inb(0x80) or post_code(POST_SMBUS_DELAY):
make up your minds :)

Extra #include post_codes:
*mrnuke starts chopping


> Can we put this in one file together with
>   src/include/cpu/amd/geode_post_code.h

Looks interesting. Looking into that. Using this will totally obsolete
documentation/POSTCODES, which I used as the basis. If you prefer to use
these codes, say "green".

>   src/include/cpu/x86/post_code.h

No. This would ruin the behavior of post_code() in console.c, which also
outputs to console if the option is selected.

On 02/25/2011 11:59 PM, Stefan Reinauer wrote:
> 
> refactored... should we move the delay function to a common place?
> 
I can move it. Just which file ? Also, wouldn't this make a single patch
too hard to swallow?

Alex





More information about the coreboot mailing list