[coreboot] Coreboot for AMD Fusion family 14h: ASRock E350M1

[Scott Duplichan]

Stefan Reinauer wrote: 

]> +#define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)

]if CONFIG_SIO_PORT is defined in Kconfig (why?) we could as well use it
]in romstage.c. Is there a chance to remove it from Kconfig instead?

Certainly the two occurrences of 2e is not ideal. This change works:

-#define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)
+#define SERIAL_DEV PNP_DEV(CONFIG_SIO_PORT, W83627HF_SP1)

I believe most SIOs have a strap option for 4e, so presumably this
address needs to be project selectable by some method. Phoenix
legacy BIOS actually figures it out at runtime. That method seems
dangerous to me and makes stepping through the code tedious.

If we remove it from kconfig, would it just be local to romstage.c?
I suppose this would be a separate patch, given the number of projects
affected.

Thanks,
Scott