[coreboot] [PATCH] Add .text into romstage sections.

[Bao, Zheng]

The ldscript_fallback_cbfs.lb is only for the romstage. It does nothing to change the building of ramstage. And it doesn't have area like .data,
which can be read and wrote.

>From the attached build output, we can see that only crt0.romstage.o changes .rodata to rom.data, changes .text to .rom.text. 
Other romstage files like console.romstage.o only have .text., without .rom.text, .rom.data, or .data.

>From the 2 romstage.map(s), we can see where the _erom should be.

Compared to the patch to ldscript_fallback_cbfs.lb, we can also change other romstage's .text to .rom.text. But I don't think it is worth to do such a complicated job.

Zheng

-----Original Message-----
From: Marc Jones [mailto:marcj303 at gmail.com] 
Sent: Wednesday, February 23, 2011 5:25 AM
To: Bao, Zheng
Cc: coreboot at coreboot.org
Subject: Re: [coreboot] [PATCH] Add .text into romstage sections.

On Tue, Feb 22, 2011 at 4:24 AM, Bao, Zheng <Zheng.Bao at amd.com> wrote:
> The text sections in *.romstage.o are called .text instead of .rom.text.
>
> The .text can be built in, but the _erom cannot be calculated correctly
>
> without this patch. Nobody uses _erom currently, so nobody seems cares it.
>
>
>
> Signed-off-by: Zheng Bao <zheng.bao at amd.com>
>
>
>
> Index: src/arch/x86/init/ldscript_fallback_cbfs.lb
>
> ===================================================================
>
> --- src/arch/x86/init/ldscript_fallback_cbfs.lb (revision 6374)
>
> +++ src/arch/x86/init/ldscript_fallback_cbfs.lb (working copy)
>
> @@ -35,6 +35,7 @@
>
>     .rom . : {
>
>           _rom = .;
>
>           *(.rom.text);
>
> +          *(.text);
>
>           *(.rom.data);
>
>           *(.rodata);
>
>           *(.rodata.*);

Zheng,

I think that .text should be like .data. and should only be in
ramstage. Is something being built into romstage that shouldn't be?

Marc



-- 
http://se-eng.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: build_output
Type: application/octet-stream
Size: 2740 bytes
Desc: build_output
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110223/d5896884/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: romstage.map.dest
Type: application/octet-stream
Size: 17932 bytes
Desc: romstage.map.dest
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110223/d5896884/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: romstage.map.orig
Type: application/octet-stream
Size: 17932 bytes
Desc: romstage.map.orig
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110223/d5896884/attachment-0002.obj>