[coreboot] [PATCH 2/3] Handle compiler options for source classes more generically

Stefan Reinauer stefan.reinauer at coreboot.org
Thu Feb 17 20:02:04 CET 2011


* Patrick Georgi <Patrick.Georgi at secunet.com> [110217 09:55]:
> Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
> index 0754b15..a233c13 100644
> --- a/Makefile
> +++ b/Makefile
  
> -$(eval $(call create_cc_template,driver,S,-DASSEMBLY))
> -$(eval $(call create_cc_template,smm,c))
> -$(eval $(call create_cc_template,smm,S))

Interesting. I think smm,S should have had -DASSEMBLY, too.

Well, even better would be to use __ASSEMBLY__ or __ASSEMBLER__ in the
code as defined by gcc for this purpose and not treat them differently
at all.

Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>





More information about the coreboot mailing list