[coreboot] [commit] r6354 - trunk/src/southbridge/amd/rs690

repository service svn at coreboot.org
Mon Feb 14 20:19:59 CET 2011


Author: oxygene
Date: Mon Feb 14 20:19:58 2011
New Revision: 6354
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6354

Log:
Removed LPC DMA Deadlock workaround...

Setting bit#21 in k8_f0#68 is part of the errata#169
which is handled in amdk8/coherent.c

Signed-off-by: Josef Kellermann <seppk at arcor.de>
Acked-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>

Modified:
   trunk/src/southbridge/amd/rs690/gfx.c

Modified: trunk/src/southbridge/amd/rs690/gfx.c
==============================================================================
--- trunk/src/southbridge/amd/rs690/gfx.c	Mon Feb 14 20:15:36 2011	(r6353)
+++ trunk/src/southbridge/amd/rs690/gfx.c	Mon Feb 14 20:19:58 2011	(r6354)
@@ -114,7 +114,7 @@
 {
 	u32 l_dword;
 	int i;
-	device_t k8_f0 = 0, k8_f2 = 0;
+	device_t k8_f2 = 0;
 	device_t nb_dev = dev_find_slot(0, 0);
 
 	printk(BIOS_INFO, "rs690_internal_gfx_enable dev=0x%p, nb_dev=0x%p.\n", dev,
@@ -129,13 +129,6 @@
 	/* set TOM */
 	rs690_set_tom(nb_dev);
 
-	/* LPC DMA Deadlock workaround? */
-	k8_f0 = dev_find_slot(0, PCI_DEVFN(0x18, 0));
-	l_dword = pci_read_config32(k8_f0, 0x68);
-	l_dword &= ~(1 << 22);
-	l_dword |= (1 << 21);
-	pci_write_config32(k8_f0, 0x68, l_dword);
-
 	/* Enable 64bit mode. */
 	set_nbmc_enable_bits(nb_dev, 0x5f, 0, 1 << 9);
 	set_nbmc_enable_bits(nb_dev, 0xb0, 0, 1 << 8);




More information about the coreboot mailing list