[coreboot] [PATCH] kbd: wait longer for self-test on keyboard reset

Peter Stuge peter at stuge.se
Wed Dec 14 08:45:46 CET 2011


Mathias Krause wrote:
> Some keyboards take pretty long to respond to a reset command,

I've pushed this to Gerrit.

> Since I was unable to download the git tree (why is it HTTP only,
> btw?)

You can also access the Git repo using SSH. Please do that. You'll
need to create a user in Gerrit via the web interface, and upload
your public SSH key. Then you can push directly to Gerrit. You can't
count on someone else doing it for you, and there is a high risk that
patches get overlooked. :\

> a patch against a tarball snapshot.

Please always make a git commit and not only a patch. You can send an
email with the patch easily using git send-email, or you can format a
patch for attachment (as text/plain) using git format-patch, after
creating the commit.

I suggest using one branch per independent change, to not have any
dependencies in Gerrit, even though they are really only advisory.

The patch looks generally fine, but what about changing the 0x61 port
to 0x65? That was an error all along?


More information about the coreboot mailing list