[coreboot] New patch to review: 193878d libpayload: EHCI registers are volatile

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Aug 16 15:48:40 CEST 2011


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/155

-gerrit

commit 193878daff4270d483257bea167e324e95b3ddec
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Tue Aug 16 15:47:15 2011 +0200

    libpayload: EHCI registers are volatile
    
    Some gcc versions seem to honor volatile at different places in a
    struct declaration.
    
    Change-Id: I0df2a3fb2eff4cee8cc1b8ac15d9cd9b86178752
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 payloads/libpayload/drivers/usb/ehci_private.h |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/ehci_private.h b/payloads/libpayload/drivers/usb/ehci_private.h
index e63a81d..f4890cc 100644
--- a/payloads/libpayload/drivers/usb/ehci_private.h
+++ b/payloads/libpayload/drivers/usb/ehci_private.h
@@ -37,7 +37,7 @@
 #define FLADJ 0x61
 #define FLADJ_framelength(x) (((x)-59488)/16)
 
-typedef union {
+typedef volatile union {
 	u32 val;
 	volatile struct {
 		unsigned long current_conn_status:1;
@@ -62,7 +62,7 @@ typedef union {
 	} __attribute__ ((packed));
 } __attribute__ ((packed)) portsc_t;
 
-typedef struct {
+typedef volatile struct {
 	u8 caplength;
 	u8 res1;
 	u16 hciversion;
@@ -117,7 +117,7 @@ typedef struct {
 	};
 } __attribute__ ((packed)) hc_cap_t;
 
-typedef struct {
+typedef volatile struct {
 	union {
 		u32 usbcmd;
 		volatile struct {
@@ -174,7 +174,7 @@ typedef struct {
 	portsc_t portsc[0];
 } hc_op_t;
 
-typedef struct {
+typedef volatile struct {
 	union {
 		u32 next_qtd;
 		struct {
@@ -223,7 +223,7 @@ typedef struct {
 	u32 bufptrs64[5];
 } __attribute__ ((packed)) qtd_t;
 
-typedef struct {
+typedef volatile struct {
 	union {
 		u32 horiz_link_ptr;
 		struct {




More information about the coreboot mailing list