[coreboot] New patch to review: 6bd82fc buildgcc: improve portability

Jonathan A. Kollasch (jakllsch@kollasch.net) gerrit at coreboot.org
Thu Aug 11 21:47:45 CEST 2011


Jonathan A. Kollasch (jakllsch at kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/150

-gerrit

commit 6bd82fc8b8a6b274bd565798d697ae5a88867c67
Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
Date:   Thu Aug 11 14:44:55 2011 -0500

    buildgcc: improve portability
    
    `cp --remove-destination` isn't as portable as `rm -f` and `cp`.
    
    Change-Id: Ib05bfc121f7a0b467f8104920e14fbd02191585f
    Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
---
 util/crossgcc/buildgcc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index e97a651..e58b23e 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -463,7 +463,8 @@ printf "Building IASL ${IASL_VERSION} ... "
 	rm -f .failed
 	CFLAGS="$HOSTCFLAGS"
 	$MAKE || touch .failed
-	cp --remove-destination iasl* $DESTDIR$TARGETDIR/bin || touch .failed
+	rm -f $DESTDIR$TARGETDIR/bin/iasl || touch .failed
+	cp iasl $DESTDIR$TARGETDIR/bin || touch .failed
 	if [ ! -f .failed ]; then touch .success; fi
 ) &> $IASL_DIR/compiler/crossgcc-build.log
 test -r $IASL_DIR/compiler/.failed && printf "${RED}failed${NC}\n" || printf "${green}ok${NC}\n"




More information about the coreboot mailing list