[coreboot] New patch to review: 36161df Do not compile nuvoton superio for all board

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Wed Aug 3 16:22:35 CEST 2011


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/129

-gerrit

commit 36161df7a4fb2733be2659fa2a395cccc27907ba
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Aug 3 09:14:59 2011 -0500

    Do not compile nuvoton superio for all board
    
    The nuvoton WPCM450 code is compiled for all boards regardless of
    whether or not they use it. Compile it only for boards needing it.
    
    Change-Id: Iaf4cf2c479eb3238863f0771be799f02a8cc3421
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/mainboard/supermicro/h8qgi/Kconfig       |    1 +
 src/mainboard/supermicro/h8scm_fam10/Kconfig |    1 +
 src/superio/nuvoton/Makefile.inc             |    2 +-
 src/superio/nuvoton/wpcm450/Makefile.inc     |    2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/supermicro/h8qgi/Kconfig b/src/mainboard/supermicro/h8qgi/Kconfig
index 286cb17..22760d2 100755
--- a/src/mainboard/supermicro/h8qgi/Kconfig
+++ b/src/mainboard/supermicro/h8qgi/Kconfig
@@ -28,6 +28,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select SOUTHBRIDGE_AMD_SR5650
 	select SOUTHBRIDGE_AMD_SP5100
 	select SUPERIO_WINBOND_W83627DHG
+	select SUPERIO_NUVOTON_WPCM450
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
diff --git a/src/mainboard/supermicro/h8scm_fam10/Kconfig b/src/mainboard/supermicro/h8scm_fam10/Kconfig
index 7742133..cbd3119 100755
--- a/src/mainboard/supermicro/h8scm_fam10/Kconfig
+++ b/src/mainboard/supermicro/h8scm_fam10/Kconfig
@@ -10,6 +10,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SOUTHBRIDGE_AMD_SR5650
 	select SOUTHBRIDGE_AMD_SP5100
 	select SUPERIO_WINBOND_W83627HF
+	select SUPERIO_NUVOTON_WPCM450
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
 	select GENERATE_PIRQ_TABLE
diff --git a/src/superio/nuvoton/Makefile.inc b/src/superio/nuvoton/Makefile.inc
index 2f2ea96..4553dd8 100644
--- a/src/superio/nuvoton/Makefile.inc
+++ b/src/superio/nuvoton/Makefile.inc
@@ -17,4 +17,4 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 ##
 
-subdirs-y += wpcm450
+subdirs-$(CONFIG_SUPERIO_NUVOTON_WPCM450) += wpcm450
diff --git a/src/superio/nuvoton/wpcm450/Makefile.inc b/src/superio/nuvoton/wpcm450/Makefile.inc
index db88097..c70b2fb 100644
--- a/src/superio/nuvoton/wpcm450/Makefile.inc
+++ b/src/superio/nuvoton/wpcm450/Makefile.inc
@@ -18,6 +18,6 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 ##
 
-romstage-$(CONFIG_SUPERIO_NUVOTON_WPCM450) += early_init.c
+romstage-y += early_init.c
 ramstage-$(CONFIG_SUPERIO_NUVOTON_WPCM450) += superio.c
 




More information about the coreboot mailing list