[coreboot] potentially wrong uses of ifdef/if defined

Alex G. mr.nuke.me at gmail.com
Tue Apr 19 12:22:33 CEST 2011


On 04/19/2011 04:33 AM, Stefan Reinauer wrote:
> ./src/northbridge/amd/amdk8/coherent_ht.c:#ifndef CONFIG_K8_HT_FREQ_1G_SUPPORT
#ifndef CONFIG_K8_HT_FREQ_1G_SUPPORT
	#define CONFIG_K8_HT_FREQ_1G_SUPPORT 0
#endif

> ./src/northbridge/amd/amdk8/coherent_ht.c:#ifndef
> CONFIG_MAX_PHYSICAL_CPUS_4_BUT_MORE_INSTALLED
#ifndef CONFIG_MAX_PHYSICAL_CPUS_4_BUT_MORE_INSTALLED
	#define CONFIG_MAX_PHYSICAL_CPUS_4_BUT_MORE_INSTALLED 0
#endif

> ./src/northbridge/amd/amdk8/coherent_ht.c:#ifndef CONFIG_ENABLE_APIC_EXT_ID
#ifndef CONFIG_ENABLE_APIC_EXT_ID
	#define CONFIG_ENABLE_APIC_EXT_ID 0
#endif

These lines can just be deleted.
Alex




More information about the coreboot mailing list