[coreboot] [patch] allow new amd agesa code to skip check for globals in romstage

Stefan Reinauer stefan.reinauer at coreboot.org
Mon Apr 18 01:58:16 CEST 2011

On 4/17/11 2:37 PM, Scott Duplichan wrote:
> Recently the 3 projects using the new AMD reference code have been
> failing the check for globals (or statics) in romstage. This causes
> ASRock E350M1, AMD Inagua, and AMD Persimmon builds to fail with the
> message "Do not use global variables in romstage". The message is
> working as intended. It is detecting data declared as 'static' when
> 'static const' was intended. The code executes correctly because it
> never tries to modify the data.
> To make reference code updates easy, it is probably best to avoid
> modifying the AMD provided code if possible. The following change
> bypasses the "Do not use global variables in romstage" check for
> the AMD reference code only.
> Signed-off-by: Scott Duplichan<scott at notabs.org>

I think AMD is working on a fix for this problem. However, until then:

Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

More information about the coreboot mailing list