[coreboot] [patch] allow new amd agesa code to skip check for globals in romstage

Scott Duplichan scott at notabs.org
Sun Apr 17 23:37:12 CEST 2011

Recently the 3 projects using the new AMD reference code have been
failing the check for globals (or statics) in romstage. This causes
ASRock E350M1, AMD Inagua, and AMD Persimmon builds to fail with the
message "Do not use global variables in romstage". The message is
working as intended. It is detecting data declared as 'static' when
'static const' was intended. The code executes correctly because it
never tries to modify the data.

To make reference code updates easy, it is probably best to avoid
modifying the AMD provided code if possible. The following change
bypasses the "Do not use global variables in romstage" check for
the AMD reference code only.

Signed-off-by: Scott Duplichan <scott at notabs.org>

Index: src/arch/x86/init/bootblock.ld
--- src/arch/x86/init/bootblock.ld	(revision 6510)
+++ src/arch/x86/init/bootblock.ld	(working copy)
@@ -48,6 +48,8 @@
-	}
-	_bogus = ASSERT((SIZEOF(.bss) + SIZEOF(.data)) == 0, "Do not use global variables in romstage");
+	}
+	_bogus = ASSERT((SIZEOF(.bss) + SIZEOF(.data)) == 0 || CONFIG_AMD_AGESA, "Do not use global variables in romstage");

-------------- next part --------------
A non-text attachment was scrubbed...
Name: agesa-waiver.patch
Type: application/octet-stream
Size: 570 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110417/bbe409c0/attachment.obj>

More information about the coreboot mailing list