[coreboot] [PATCH] Unify the Socket 940 CAR configuration.

Myles Watson mylesgw at gmail.com
Thu Sep 30 23:58:28 CEST 2010


> I am looking for some comments on the following patch. It unifies the
> socket 940 cache-as-ram implementation. Previously, the affected boards
> had their own CAR options in their Kconfig files. There is a default set
> of CAR configs in the socket.
> 
> Does anyone have comments on why this patch should or should not be
> committed?

Pro:
It's simpler.

Con:
It probably slows booting a little, since there's more stack to copy.  I
have no idea how much.

The code handles either CAR size already, so it shouldn't break anything.

Thanks,
Myles






More information about the coreboot mailing list