[coreboot] [commit] r5869 - in trunk: . util/abuild
repository service
svn at coreboot.org
Mon Sep 27 23:14:20 CEST 2010
Author: stepan
Date: Mon Sep 27 23:14:19 2010
New Revision: 5869
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5869
Log:
The commandline parsing for abuild doing a couple of buggy things:
* Long options of the form --opt=arg were not having the arg stripped
off into a another argument in the output. As a result, all long
options with args had to be written like "--opt arg" on the command
line to be recognized.
* The --remove option was shifting too many times.
As a bonus, I also added some logic to make "make distclean" cleanup
the default abuild build dir.
Signed-off-by: Warren Turkal <wt at penguintechs.org>
Acked-by: Stefan Reinauer <stepan at coresystems.de>
Modified:
trunk/Makefile
trunk/util/abuild/abuild
Modified: trunk/Makefile
==============================================================================
--- trunk/Makefile Mon Sep 27 23:11:54 2010 (r5868)
+++ trunk/Makefile Mon Sep 27 23:14:19 2010 (r5869)
@@ -358,10 +358,13 @@
clean: clean-for-update
rm -f $(obj)/coreboot* .ccwrap
+clean-abuild:
+ rm -rf coreboot_builds
+
clean-cscope:
rm -f cscope.out
-distclean: clean-cscope
+distclean: clean-cscope clean-abuild
rm -rf $(obj)
rm -f .config .config.old ..config.tmp .kconfig.d .tmpconfig* .ccwrap .xcompile
@@ -390,5 +393,5 @@
@# http://www.coreboot.org/pipermail/coreboot/2010-February/055825.html
$(HOSTCC) -g $(STACK) -Wall -o $@ $<
-.PHONY: $(PHONY) clean clean-cscope cscope distclean doxygen doxy coreboot .xcompile
+.PHONY: $(PHONY) clean clean-abuild clean-cscope cscope distclean doxygen doxy coreboot .xcompile
Modified: trunk/util/abuild/abuild
==============================================================================
--- trunk/util/abuild/abuild Mon Sep 27 23:11:54 2010 (r5868)
+++ trunk/util/abuild/abuild Mon Sep 27 23:14:19 2010 (r5869)
@@ -570,8 +570,8 @@
getoptbrand="`getopt -V`"
if [ "${getoptbrand:0:6}" == "getopt" ]; then
# Detected GNU getopt that supports long options.
- args=`getopt -l version,verbose,help,all,target:,broken,payloads:,test,cpus:,silent,xml,config,loglevel:,remove,prefix:,update,nostackprotect,scan-build,ccache Vvhat:bp:Tc:sxCl:rP:uy -- "$@"`
- eval set "$args"
+ args=`getopt -l version,verbose,help,all,target:,broken,payloads:,test,cpus:,silent,xml,config,loglevel:,remove,prefix:,update,nostackprotect,scan-build,ccache -o Vvhat:bp:Tc:sxCl:rP:uy -- "$@"`
+ eval set -- $args
else
# Detected non-GNU getopt
args=`getopt Vvhat:bp:Tc:sxCl:rP:uy $*`
@@ -589,7 +589,7 @@
-t|--target) shift; target="$1"; shift;;
-a|--all) shift; buildall=true;;
-b|--broken) shift; buildbroken=true;;
- -r|--remove) shift; remove=true; shift;;
+ -r|--remove) shift; remove=true;;
-v|--verbose) shift; verbose=true; silent='V=1';;
-V|--version) shift; myversion; exit 0;;
-h|--help) shift; myversion; myhelp; exit 0;;
More information about the coreboot
mailing list